Skip to content

Added a note about using ":" in Redis passwords #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2017
Merged

Added a note about using ":" in Redis passwords #7739

merged 1 commit into from
Apr 15, 2017

Conversation

javiereguiluz
Copy link
Member

This fixes #7531.

viviengaetan
viviengaetan approved these changes Apr 13, 2017
View reviewed changes
Copy link
Contributor

@viviengaetan viviengaetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

xabbuh
xabbuh approved these changes Apr 14, 2017
View reviewed changes
components/cache/cache_pools.rst
``:`` character (e.g. ``foo:bar`` password would be wrongly parsed as ``foo``
login + ``bar`` password). The solution is to add a fake login to the
connection DSN. Instead of ``'redis://foo:bar@localhost'``, use
``'redis://__ignore_this__:foo:bar@localhost'``
Copy link
Member

@xabbuh xabbuh Apr 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing trailing dot

@xabbuh
Copy link
Member

xabbuh commented Apr 15, 2017

Thank you Javier.

@xabbuh xabbuh merged commit 9de2e8c into symfony:3.2 Apr 15, 2017
xabbuh added a commit that referenced this pull request Apr 15, 2017
@xabbuh
minor #7739 Added a note about using ":" in Redis passwords (javiereg…
497be1f 
…uiluz)

This PR was merged into the 3.2 branch.

Discussion
----------

Added a note about using ":" in Redis passwords

This fixes #7531.

Commits
-------

9de2e8c Added a note about using ":" in Redis passwords
xabbuh added a commit that referenced this pull request Apr 15, 2017
@xabbuh
[#7739] add missing dot
3e74145
@weaverryan
Copy link
Member

I don't know enough about Redis, but is this correct? Is there never a username? SncRedisBundle seems to suggest that there can be a username: https://github.com/snc/SncRedisBundle/blob/master/Tests/DependencyInjection/Configuration/RedisDsnTest.php#L203-L204

If you can have a username, then this needs to be tweaked. If you cannot have a username, then the master branch needs some work - it has expanded redis details (redis_apdapter.rst not sure why it's so different on master) that show the use of a username

@xabbuh
Copy link
Member

xabbuh commented Apr 15, 2017

@nicolas-grekas Can you help us here?

@nicolas-grekas
Copy link
Member

No username, only a password

@viviengaetan
Copy link
Contributor

viviengaetan commented Apr 15, 2017 •
edited
Loading

They are only speaking about password in their manual
Edit: @weaverryan if you look the method of your link - it's only about testing password.

@javiereguiluz javiereguiluz deleted the fix_7531 branch May 24, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viviengaetan viviengaetan viviengaetan approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@javiereguiluz @xabbuh @weaverryan @nicolas-grekas @viviengaetan @carsonbot